-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds events section #93
feat: adds events section #93
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I request a few adjustments:
-
1. Kindly delete the 6
Rectangle XX.png
images that came from Figma. Sorry for the confusion. These were placeholder images in the design but we intend to load our own images that are linked in theevents.json
. -
2. For better organization, let us create a new folder named
Events
inside thecomponents
folder and move thesrc/components/Events.tsx
andsrc/components/DisplayRC.tsx
files in there.
src/components/Events.tsx ➜ src/components/Events/Events.tsx
src/components/DisplayRC.tsx ➜ src/components/Events/DisplayRC.tsx
- 3. Run prettier
npm run prettier:format
to format your files.
Done, with the changes needed. |
the test you've given is perfect, it works well for chrome, firefox but not safari.
If you're not experiencing this issue and all tests are passing in all the 3 browsers,, just ignore this. It maybe an issue with my environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Requirements to be achieved
Create a component named Events in the components folder that implements the screenshots below.
It should render a section tag with an id of events.
It should make use of the existing DisplayRC component - feel free to adjust the DisplayRC component to match the requirements in this ticket.
Use the events.json data shown below.
Obtain the images from the Figma design. Use THIS VIDEO as a guide
The images should use the Next Image component.
Include the component in index.page.tsx
Create a new test file in the e2e folder named events.spec.ts and add a test that verifies that clicking the "See More" link in the component navigates to the correct URL HERE.
Check List (Check all the applicable boxes)
Screenshots
Implementation of the design
![events-section](https://user-images.githubusercontent.com/31630507/196266609-a36dbdb2-ec0e-4b10-a6b9-ca9d03798d6a.png)
Testing of the events section
![events-specs ts](https://user-images.githubusercontent.com/31630507/196266740-93f92733-3e6d-469c-b26f-525988f78e28.png)
Note to reviewers